Remove the fixit for the diagnostics regarding capturing autoreleasing variables...
authorGeorge Karpenkov <ekarpenkov@apple.com>
Mon, 14 May 2018 20:29:16 +0000 (20:29 +0000)
committerGeorge Karpenkov <ekarpenkov@apple.com>
Mon, 14 May 2018 20:29:16 +0000 (20:29 +0000)
commit098f0080da0497489dfb409337cb433723a610e8
tree5624b0ce8559a26c3cc733c15da4665c6f63ff5f
parent7129e63bcce96529291b3ffbe596f7f8588bdcc4
Remove the fixit for the diagnostics regarding capturing autoreleasing variables in a block

The fixit is actively harmful, as it encourages developers to ignore the
warning and to write unsafe code.
It is almost impossible to write safe code while capturing autoreleasing
variables in the block, as in order to check that the block is never
called in the autoreleasing pool the developer has to check the
transitive closure of all potential callers of the block.

Differential Revision: https://reviews.llvm.org/D46778

llvm-svn: 332288
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaExpr.cpp
clang/test/SemaObjC/arc.m