Fixing another clusterfuzz issue
authorsugoi <sugoi@chromium.org>
Fri, 6 Jun 2014 13:44:16 +0000 (06:44 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 6 Jun 2014 13:44:17 +0000 (06:44 -0700)
commit0951fe12984944406e0f1bb105b9fa4c54fcdcdd
tree03fe9c0a489b34b1f9e60701e9c0501ae08a9974
parent5102345029be75f089e083228e317545627ea1cb
Fixing another clusterfuzz issue

This was introduced by removing SkValidatingReadBuffer::readBitmap in https://codereview.chromium.org/295793002/

Since SkReadBuffer::skip wasn't virtual, it was using the unsafe SkReadBuffer::skip within SkReadBuffer::readBitmap rather than using SkValidatingReadBuffer::skip. I also removed direct uses of fReader within SkReadBuffer::readBitmap so that it can use the virtual readInt / readFixed functions that have a version in SkValidatingReadBuffer.

Also, I changed SkReadBuffer::readPoint so that it uses the virtual readScalar, that way, it becomes redundant with SkValidatingReadBuffer::readPoint, which can then be removed.

BUG=380723
R=reed@google.com, mtklein@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/317003003
include/core/SkReadBuffer.h
src/core/SkReadBuffer.cpp
src/core/SkValidatingReadBuffer.h