tty: fix data race between tty_init_dev and flush of buf
authorGaurav Kohli <gkohli@codeaurora.org>
Tue, 23 Jan 2018 07:46:34 +0000 (13:16 +0530)
committerYixun Lan <yixun.lan@amlogic.com>
Wed, 4 Apr 2018 02:49:37 +0000 (18:49 -0800)
commit092f4c15aa8ec528890ecfe82e309c762ec42a0b
treec480a112cb2ed416bad565261e395bb41453e5a7
parentdf1d0cddf720ebc6a79c24f8536bd89a01afa0f9
tty: fix data race between tty_init_dev and flush of buf

PD#163025: fix pwq null pointer

commit b027e2298bd588d6fa36ed2eda97447fb3eac078 upstream.

There can be a race, if receive_buf call comes before
tty initialization completes in n_tty_open and tty->disc_data
may be NULL.

CPU0 CPU1
---- ----
 000|n_tty_receive_buf_common()    n_tty_open()
-001|n_tty_receive_buf2() tty_ldisc_open.isra.3()
-002|tty_ldisc_receive_buf(inline) tty_ldisc_setup()

Using ldisc semaphore lock in tty_init_dev till disc_data
initializes completely.

Change-Id: I8a9d58a674e0267c2eda3c6bf58c7510e86e3b33
Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>
Reviewed-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_io.c
drivers/tty/tty_ldisc.c
include/linux/tty.h