Input: evdev - call input_flush_device() on release(), not flush()
authorBrendan Shanks <bshanks@codeweavers.com>
Wed, 22 Apr 2020 20:45:12 +0000 (13:45 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 22 Apr 2020 21:15:04 +0000 (14:15 -0700)
commit09264098ff153f60866039d60b31d39b66f55a31
treef84241541ac1987f3fbcb0e7c59e239863566671
parent18931506465a762ffd3f4803d36a18d336a67da9
Input: evdev - call input_flush_device() on release(), not flush()

input_flush_device() should only be called once the struct file is being
released and no open descriptors remain, but evdev_flush() was calling
it whenever a file descriptor was closed.

This caused uploaded force-feedback effects to be erased when a process
did a dup()/close() on the event FD, called system(), etc.

Call input_flush_device() from evdev_release() instead.

Reported-by: Mathieu Maret <mathieu.maret@gmail.com>
Signed-off-by: Brendan Shanks <bshanks@codeweavers.com>
Link: https://lore.kernel.org/r/20200421231003.7935-1-bshanks@codeweavers.com
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/evdev.c