mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards_init
authorZhengchao Shao <shaozhengchao@huawei.com>
Fri, 30 Jun 2023 01:26:47 +0000 (09:26 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 30 Jun 2023 02:10:07 +0000 (19:10 -0700)
commit08fc75735fda3be97194bfbf3c899c87abb3d0fe
tree0ea9b66be4db5c982e0002bbfa3f5bbcfdf6e7fa
parent3cf62c8177adb0db9e15c8b898c44f997acf3ebf
mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards_init

The line cards array is not freed in the error path of
mlxsw_m_linecards_init(), which can lead to a memory leak. Fix by
freeing the array in the error path, thereby making the error path
identical to mlxsw_m_linecards_fini().

Fixes: 01328e23a476 ("mlxsw: minimal: Extend module to port mapping with slot index")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/r/20230630012647.1078002-1-shaozhengchao@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/minimal.c