Forbid creation of non-faulting null-check nodes. (#77078)
authorJulie Lee <63486087+JulieLeeMSFT@users.noreply.github.com>
Sat, 28 Jan 2023 02:02:21 +0000 (18:02 -0800)
committerGitHub <noreply@github.com>
Sat, 28 Jan 2023 02:02:21 +0000 (18:02 -0800)
commit08f13ddf7760653d62077c1b46dee1c0335c2e0e
tree1dd7716dce3c5fdf16d0cf43d11c94e2ccadbed2
parentce66d01e9628cda5aa4439c39e26138304571463
Forbid creation of non-faulting null-check nodes. (#77078)

* Forbid creation of non-faulting null-check nodes.

* Skip null check if op1 cannot be null.

* x86 bug fix for Skip gtChangeOperToNullCheck if it cannot be null.

* Fix Arm64 AVE: Do not lower indir when NOP.

* formatting fix.

* Arm64 regression bug fix that removes const bool for a variable.

* Preserve const and shorten expression.

* Fix format.

* Addressed code review feedback

* Forbid creation of non-faulting nullcheck node: Addressed feedback

* Forbid creation of non-faulting null-check nodes: Remove duplicate codes that was supposed to be deleted.
src/coreclr/jit/compiler.cpp
src/coreclr/jit/gentree.cpp
src/coreclr/jit/importer.cpp
src/coreclr/jit/lower.cpp