NLM: nlm_lookup_file() may return NLMv4-specific error codes
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Sat, 13 Oct 2012 04:30:28 +0000 (00:30 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 28 Oct 2012 17:14:13 +0000 (10:14 -0700)
commit08eaf6a4ee82eb566c188f71b33f52e780fab57d
tree5542ba56a9cd7feccae5af3bbde61248537ba5bf
parent75383fac9206c9dc57a5f153ffabcd5341ad0c28
NLM: nlm_lookup_file() may return NLMv4-specific error codes

commit cd0b16c1c3cda12dbed1f8de8f1a9b0591990724 upstream.

If the filehandle is stale, or open access is denied for some reason,
nlm_fopen() may return one of the NLMv4-specific error codes nlm4_stale_fh
or nlm4_failed. These get passed right through nlm_lookup_file(),
and so when nlmsvc_retrieve_args() calls the latter, it needs to filter
the result through the cast_status() machinery.

Failure to do so, will trigger the BUG_ON() in encode_nlm_stat...

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Reported-by: Larry McVoy <lm@bitmover.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/lockd/clntxdr.c
fs/lockd/svcproc.c