riscv: Implement syscall wrappers
authorSami Tolvanen <samitolvanen@google.com>
Mon, 10 Jul 2023 18:35:46 +0000 (18:35 +0000)
committerPalmer Dabbelt <palmer@rivosinc.com>
Wed, 23 Aug 2023 21:16:36 +0000 (14:16 -0700)
commit08d0ce30e0e4fcb5f06c90fe40387b1ce9324833
tree69f769ebd80061215865aa13bc4bc301ab4e446f
parent06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
riscv: Implement syscall wrappers

Commit f0bddf50586d ("riscv: entry: Convert to generic entry") moved
syscall handling to C code, which exposed function pointer type
mismatches that trip fine-grained forward-edge Control-Flow Integrity
(CFI) checks as syscall handlers are all called through the same
syscall_t pointer type. To fix the type mismatches, implement pt_regs
based syscall wrappers similarly to x86 and arm64.

This patch is based on arm64 syscall wrappers added in commit
4378a7d4be30 ("arm64: implement syscall wrappers"), where the main goal
was to minimize the risk of userspace-controlled values being used
under speculation. This may be a concern for riscv in future as well.

Following other architectures, the syscall wrappers generate three
functions for each syscall; __riscv_<compat_>sys_<name> takes a pt_regs
pointer and extracts arguments from registers, __se_<compat_>sys_<name>
is a sign-extension wrapper that casts the long arguments to the
correct types for the real syscall implementation, which is named
__do_<compat_>sys_<name>.

Reviewed-by: Kees Cook <keescook@chromium.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Link: https://lore.kernel.org/r/20230710183544.999540-9-samitolvanen@google.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/Kconfig
arch/riscv/include/asm/syscall.h
arch/riscv/include/asm/syscall_wrapper.h [new file with mode: 0644]
arch/riscv/kernel/compat_syscall_table.c
arch/riscv/kernel/sys_riscv.c
arch/riscv/kernel/syscall_table.c