nvdimm: Fix dereference after free in register_nvdimm_pmu()
authorKonstantin Meskhidze <konstantin.meskhidze@huawei.com>
Thu, 17 Aug 2023 11:41:03 +0000 (19:41 +0800)
committerDave Jiang <dave.jiang@intel.com>
Thu, 17 Aug 2023 16:34:03 +0000 (09:34 -0700)
commit08ca6906a4b7e48f8e93b7c1f49a742a415be6d5
treeb7597ea1edeb33c25ddb8764cec9f40f7ae210c6
parent85ae42c72142346645e63c33835da947dfa008b3
nvdimm: Fix dereference after free in register_nvdimm_pmu()

'nd_pmu->pmu.attr_groups' is dereferenced in function
'nvdimm_pmu_free_hotplug_memory' call after it has been freed. Because in
function 'nvdimm_pmu_free_hotplug_memory' memory pointed by the fields of
'nd_pmu->pmu.attr_groups' is deallocated it is necessary to call 'kfree'
after 'nvdimm_pmu_free_hotplug_memory'.

Fixes: 0fab1ba6ad6b ("drivers/nvdimm: Add perf interface to expose nvdimm performance stats")
Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Link: https://lore.kernel.org/r/20230817114103.754977-1-konstantin.meskhidze@huawei.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/nvdimm/nd_perf.c