Properly track whether a variable is constant-initialized.
authorRichard Smith <richard@metafoo.co.uk>
Tue, 20 Oct 2020 03:03:18 +0000 (20:03 -0700)
committerRichard Smith <richard@metafoo.co.uk>
Tue, 20 Oct 2020 06:59:11 +0000 (23:59 -0700)
commit08c8d5bc51c512e605840b8003fcf38c86d0fc96
tree0dcca8915a3abd3fbffa21ae8e2ddb72303770d3
parent1329944c221ce2187acd30920dde8d443f8dac19
Properly track whether a variable is constant-initialized.

This fixes miscomputation of __builtin_constant_evaluated in the
initializer of a variable that's not usable in constant expressions, but
is readable when constant-folding.

If evaluation of a constant initializer fails, we throw away the
evaluated result instead of keeping it as a non-constant-initializer
value for the variable, because it might not be a correct value.
To avoid regressions for initializers that are foldable but not formally
constant initializers, we now try constant-evaluating some globals in
C++ twice: once to check for a constant initializer (in an mode where
is_constannt_evaluated returns true) and again to determine the runtime
value if the initializer is not a constant initializer.
clang/include/clang/AST/Decl.h
clang/include/clang/AST/Expr.h
clang/lib/AST/Decl.cpp
clang/lib/AST/ExprConstant.cpp
clang/lib/CodeGen/CGExprConstant.cpp
clang/test/CodeGenCXX/builtin-is-constant-evaluated.cpp
clang/test/PCH/builtin-is-constant-evaluated.cpp [new file with mode: 0644]
clang/test/SemaCXX/attr-require-constant-initialization.cpp
clang/test/SemaCXX/builtin-is-constant-evaluated.cpp