untangling do_lookup() - get rid of need_reval in !dentry case
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 30 Mar 2012 18:18:50 +0000 (14:18 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 31 Mar 2012 20:03:16 +0000 (16:03 -0400)
commit08b0ab7c20f767187ae635d51bdd9d262ebe8357
treeb3b7258f1bee1574df231279dec23fe0c92a2b46
parentacc9cb3cd425f479d8fc4a441bff45dce23aa6dd
untangling do_lookup() - get rid of need_reval in !dentry case

Everything arriving into if (!dentry) will have need_reval = 1.
Indeed, the only way to get there with need_reval reset to 0 would
be via
if (unlikely(d_need_lookup(dentry)))
goto unlazy;
if (unlikely(dentry->d_flags & DCACHE_OP_REVALIDATE)) {
status = d_revalidate(dentry, nd);
if (unlikely(status <= 0)) {
if (status != -ECHILD)
need_reval = 0;
goto unlazy;
...
unlazy:
/* no assignments to dentry */
if (dentry && unlikely(d_need_lookup(dentry))) {
dput(dentry);
dentry = NULL;
}
and if d_need_lookup() had already been false the first time around, it
will remain false on the second call as well.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namei.c