[PDB][NativeSession] Clean up some things in NativeSession.
authorAmy Huang <akhuang@google.com>
Tue, 21 Jul 2020 23:54:52 +0000 (16:54 -0700)
committerAmy Huang <akhuang@google.com>
Tue, 21 Jul 2020 23:54:52 +0000 (16:54 -0700)
commit0881d0bed3aaac1f9769f2bac4852a83dd1fd8c5
tree01ec3875c81562d1b9c59d91c57ab17381c27a7b
parenta361aa5249856e333a373df90947dabf34cd6aab
[PDB][NativeSession] Clean up some things in NativeSession.

-Use the actual sect/offset to keep track of symbols in the cache so they don't get created multiple times with different addresses.
-Remove getSymTag from PDBFunctionSymbol/PDBPublicSymbol because it's already implemented in the base class
-Merge the symbolizer test files for DIA and native, since the tests are the same.
-Implement getCompilandId for NativeLineNumber

Reviewed By: amccarth

Differential Revision: https://reviews.llvm.org/D84208
12 files changed:
llvm/include/llvm/DebugInfo/PDB/Native/NativeFunctionSymbol.h
llvm/include/llvm/DebugInfo/PDB/Native/NativeLineNumber.h
llvm/include/llvm/DebugInfo/PDB/Native/NativePublicSymbol.h
llvm/include/llvm/DebugInfo/PDB/Native/SymbolCache.h
llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
llvm/lib/DebugInfo/PDB/Native/NativeLineNumber.cpp
llvm/lib/DebugInfo/PDB/Native/NativePublicSymbol.cpp
llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp
llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp
llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test [moved from llvm/test/tools/llvm-symbolizer/pdb/pdb-native-columns.test with 90% similarity]
llvm/test/tools/llvm-symbolizer/pdb/pdb-native.test [deleted file]
llvm/test/tools/llvm-symbolizer/pdb/pdb.test