netfilter: nf_tables: fix memory leak on error exit return
authorColin Ian King <colin.king@canonical.com>
Wed, 9 May 2018 12:22:56 +0000 (13:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 8 Jul 2018 13:30:49 +0000 (15:30 +0200)
commit082711fa317845b535faa0aeea7ee3ff82a08301
treedc0cc4bb64f69bad3e7f0e5fdb91bbbcd551efd1
parent174757e28b7bc261f8ddd12467786f286717a108
netfilter: nf_tables: fix memory leak on error exit return

commit f0dfd7a2b35b02030949100247d851b793cb275f upstream.

Currently the -EBUSY error return path is not free'ing resources
allocated earlier, leaving a memory leak. Fix this by exiting via the
error exit label err5 that performs the necessary resource clean
up.

Detected by CoverityScan, CID#1432975 ("Resource leak")

Fixes: 9744a6fcefcb ("netfilter: nf_tables: check if same extensions are set when adding elements")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_tables_api.c