Miscellaneous code readability improvements.
authorJoel E. Denny <jdenny@clemson.edu>
Tue, 11 Aug 2009 01:43:07 +0000 (21:43 -0400)
committerJoel E. Denny <jdenny@clemson.edu>
Tue, 11 Aug 2009 03:25:21 +0000 (23:25 -0400)
commit07c0db18b4a795a3a35a4d98b3d001bfc7d4e1c1
tree28f750e43cd98db69f7a2640bddf9c0a1d636840
parent1a323c2f7143659fa0dcbddeb3d2518275973c05
Miscellaneous code readability improvements.

* src/reader.c (reader): Move %define front-end variable
defaults and checking into...
(prepare_percent_define_front_end_variables): ... this new
function.

* src/scan-gram.l (INITIAL): For consistency with string
literals, don't store open quote on character literal.  It's
discarded before returning anyway.
(SC_ESCAPED_CHARACTER): Similarly, don't store close quote.
Make length test more readable, and make the character stored
for an empty literal more obvious while consistent with the
previous behavior.

* src/symtab.c, src/symtab.h: Rename USER_NUMBER_ALIAS to
USER_NUMBER_HAS_STRING_ALIAS throughout.
* src/symtab.c (symbol_make_alias): Remove comment from symtab.c
that is repeated in symtab.h.  Improve argument names to make it
clear which side of the symbol-string alias pair is which.
(symbol_check_alias_consistency): Improve local variable names
for the same purpose.
* src/symtab.h (struct symbol): Make comments about aliases
clearer.
(symbol_make_alias): Improve comments and argument name.
* src/output.c (token_definitions_output): Update for rename to
USER_NUMBER_HAS_STRING_ALIAS and improve comments about aliases.
(cherry picked from commit dfaa48602d4e6d329e3ae9063f44929490928b3d)

Conflicts:

src/symtab.c
src/symtab.h
ChangeLog
src/output.c
src/reader.c
src/scan-gram.l
src/symtab.c
src/symtab.h