ceph: fix type promotion bug on 32bit systems
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 7 Oct 2023 08:52:39 +0000 (11:52 +0300)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 9 Oct 2023 11:35:24 +0000 (13:35 +0200)
commit07bb00ef00ace88dd6f695fadbba76565756e55c
tree4b3c29538b04242b6750f2fdc5ac217c401abe8a
parent7563cf17dce0a875ba3d872acdc63a78ea344019
ceph: fix type promotion bug on 32bit systems

In this code "ret" is type long and "src_objlen" is unsigned int.  The
problem is that on 32bit systems, when we do the comparison signed longs
are type promoted to unsigned int.  So negative error codes from
do_splice_direct() are treated as success instead of failure.

Cc: stable@vger.kernel.org
Fixes: 1b0c3b9f91f0 ("ceph: re-org copy_file_range and fix some error paths")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/file.c