Use analyzers from targeting pack for NetCoreAppCurrent (#87726)
authorViktor Hofer <viktor.hofer@microsoft.com>
Mon, 19 Jun 2023 21:27:38 +0000 (23:27 +0200)
committerGitHub <noreply@github.com>
Mon, 19 Jun 2023 21:27:38 +0000 (23:27 +0200)
commit07ae197db5a3ee08b7b146571bd70ab731c4275e
tree8387da00ee807ec4e1697a6f4e68631f434f577b
parent903eef77d673f9ef95bf6538e5b0b8580003f0a9
Use analyzers from targeting pack for NetCoreAppCurrent (#87726)

* Use analyzers from targeting pack for NetCoreAppCurrent

Fixes that analyzer failures didn't show-up in #74897

Add analyzers to the frameworklist that OOB projects in src/libraries
use, and only auto ProjectReference the analyzers in generators.targets
when not using the analyzers from the targeting pack.

Also move the generator projects related code into a separate file.

Continuation of https://github.com/dotnet/runtime/pull/75093

* Fix project build

* Add missing reference to Regex tests

* Add missing generators for netfx build

* Fix paht in test project

* Fix typo

* Disable runtime marshalling for SharedTypes.csproj

* Disable runtime marshalling for NativeExports.csproj
31 files changed:
Directory.Build.targets
docs/coding-guidelines/project-guidelines.md
eng/generatorProjects.targets [new file with mode: 0644]
eng/generators.targets
eng/targetingpacks.targets
src/libraries/Directory.Build.targets
src/libraries/Microsoft.NET.WebAssembly.Webcil/src/Microsoft.NET.WebAssembly.Webcil.csproj
src/libraries/System.Data.Odbc/src/System.Data.Odbc.csproj
src/libraries/System.Data.OleDb/src/System.Data.OleDb.csproj
src/libraries/System.Memory.Data/tests/System.Memory.Data.Tests.csproj
src/libraries/System.Net.Http.Json/tests/FunctionalTests/System.Net.Http.Json.Functional.Tests.csproj
src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.Legacy.UnitTests/System.Runtime.InteropServices.JavaScript.Legacy.Tests.csproj
src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System.Runtime.InteropServices.JavaScript.Tests.csproj
src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/ComInterfaceGenerator.Tests.csproj
src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/Directory.Build.props [deleted file]
src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/NativeExports.csproj
src/libraries/System.Runtime.InteropServices/tests/TestAssets/SharedTypes/SharedTypes.csproj
src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj
src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.TestLibrary/System.Text.Json.TestLibrary.targets
src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/System.Text.Json.Tests.csproj
src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/System.Text.RegularExpressions.Tests.csproj
src/libraries/frameworklist.targets
src/libraries/oob.proj
src/libraries/sfx.proj
src/mono/sample/mbr/browser/WasmDelta.csproj
src/mono/sample/wasm/Directory.Build.props
src/mono/sample/wasm/browser-bench/Console/Wasm.Console.Bench.Sample.csproj
src/mono/sample/wasm/browser-bench/Wasm.Browser.Bench.Sample.csproj
src/mono/wasm/debugger/tests/debugger-test/debugger-test.csproj
src/tests/FunctionalTests/WebAssembly/Directory.Build.props