drm/file: Uncompact the feature flags
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 2 Nov 2018 13:25:42 +0000 (14:25 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 6 Nov 2018 17:23:31 +0000 (18:23 +0100)
commit078b7de41249b989a574339078696663e095cf37
tree5baf7e6b2ce9b92baab332f92e4fa1b3410c253e
parenta0c1af46e9d71fdae7df904b91542ce2518382a1
drm/file: Uncompact the feature flags

This essentially undoes

commit 39868bd7668bd47308b1dfd97c212757caee764f
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Oct 29 08:55:58 2013 +0000

    drm: Compact booleans within struct drm_file

We do lockless access to these flags everywhere, and it's kinda not a
great idea to mix lockless and bitfields. Aside from that gcc isn't
generating great code for these.

If this ever becomes an issue size-wise, I think we need atomic_t here
and atomic bitflag ops.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Herrmann <dh.herrmann@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181102132543.16486-2-daniel.vetter@ffwll.ch
include/drm/drm_file.h