dtrace-probe: Put semicolon after while on its own line
authorSimon Marchi <simon.marchi@ericsson.com>
Sun, 25 Jun 2017 10:49:19 +0000 (12:49 +0200)
committerSimon Marchi <simon.marchi@ericsson.com>
Sun, 25 Jun 2017 10:49:19 +0000 (12:49 +0200)
commit07809eafc959a0c588663c0c949eaf8044a1b40a
tree781644fbcdfd67834cfeea9959d42b0d8ef24b9c
parentf076f0349cb958b451872ce4a7987821533c2f49
dtrace-probe: Put semicolon after while on its own line

clang shows this warning.

  /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: error: while loop has empty body [-Werror,-Wempty-body]
            while (*p++ != '\0' && p - strtab < strtab_size);
                                                            ^
  /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: note: put the semicolon on a separate line to silence this warning

Putting the semicolon on its own line is not a big sacrifice to get rid of this
warning.  I think it's also useful to keep this, because it can catch errors
like this:

  while (something);
    {
      ...
    }

although gcc would warn about it in a different way (misleading indentation).

This warning is already discussed here in the GCC bugzilla:

  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62184

gdb/ChangeLog:

* dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on
its own line.
gdb/ChangeLog
gdb/dtrace-probe.c