printk: Clean up do_syslog() error handling
authorNikitas Angelinas <nikitas.angelinas@gmail.com>
Sun, 30 Jul 2017 03:36:36 +0000 (20:36 -0700)
committerPetr Mladek <pmladek@suse.com>
Tue, 15 Aug 2017 14:28:16 +0000 (16:28 +0200)
commit077a1cc06f72f95efd077d433993c16191008e47
tree5d1c7194b36b9a05315c1f12e6cba42aa792bcfa
parent5a814231ae3d4f248a8ecb668a072a1da471c656
printk: Clean up do_syslog() error handling

The error variable in do_syslog() is preemptively set to the error code
before the error condition is checked, and then set to 0 if the error
condition is not encountered. This is not necessary, as it is likely
simpler to return immediately upon encountering the error condition. A
redundant set of the error variable to 0 is also removed.

This patch has been build-tested on x86_64, but not tested for
functionality.

Link: http://lkml.kernel.org/r/20170730033636.GA935@vostro
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Nikitas Angelinas <nikitas.angelinas@gmail.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
kernel/printk/printk.c