[PeepholeOptimizer] Don't assume bitcast def always has input
authorJinsong Ji <jji@us.ibm.com>
Mon, 19 Aug 2019 14:19:04 +0000 (14:19 +0000)
committerJinsong Ji <jji@us.ibm.com>
Mon, 19 Aug 2019 14:19:04 +0000 (14:19 +0000)
commit0776da5236e032d8b2419f56ceff990a668c7d89
treef7dc6c8b6113df3ffb3b5239bcff31ce8e542938
parentc8a1dfc484c94238c01567247c0cf83584f8719c
[PeepholeOptimizer] Don't assume bitcast def always has input

Summary:
If we have a MI marked with bitcast bits, but without input operands,
PeepholeOptimizer might crash with assert.

eg:
If we apply the changes in PPCInstrVSX.td as in this patch:

[(set v4i32:$XT, (bitconvert (v16i8 immAllOnesV)))]>;

We will get assert in PeepholeOptimizer.

```
llvm-lit llvm-project/llvm/test/CodeGen/PowerPC/build-vector-tests.ll -v

llvm-project/llvm/include/llvm/CodeGen/MachineInstr.h:417: const
llvm::MachineOperand &llvm::MachineInstr::getOperand(unsigned int)
const: Assertion `i < getNumOperands() && "getOperand() out of range!"'
failed.
```

The fix is to abort if we found out of bound access.

Reviewers: qcolombet, MatzeB, hfinkel, arsenm

Reviewed By: qcolombet

Subscribers: wdng, arsenm, steven.zhang, wuzish, nemanjai, hiraditya, kbarton, MaskRay, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65542

llvm-svn: 369261
llvm/lib/CodeGen/PeepholeOptimizer.cpp
llvm/lib/Target/PowerPC/PPCInstrVSX.td
llvm/test/CodeGen/PowerPC/bitcast-peephole.mir [new file with mode: 0644]