net: fec: do not double-parse 'phy-reset-active-high' property
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 1 Feb 2023 21:53:20 +0000 (13:53 -0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 3 Feb 2023 05:12:22 +0000 (21:12 -0800)
commit0719bc3a5c77091192c57e440896a969cd1cf885
treef215b6727c5ffb068d7ef44e6ca80b75fcad11f8
parentd7b5e5dd669436328dbf41d89af09b3fa5de3b95
net: fec: do not double-parse 'phy-reset-active-high' property

Conversion to gpiod API done in commit 468ba54bd616 ("fec: convert
to gpio descriptor") clashed with gpiolib applying the same quirk to the
reset GPIO polarity (introduced in commit b02c85c9458c). This results in
the reset line being left active/device being left in reset state when
reset line is "active low".

Remove handling of 'phy-reset-active-high' property from the driver and
rely on gpiolib to apply needed adjustments to avoid ending up with the
double inversion/flipped logic.

Fixes: 468ba54bd616 ("fec: convert to gpio descriptor")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20230201215320.528319-2-dmitry.torokhov@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec_main.c