fs/kernel_read_file: Remove FIRMWARE_EFI_EMBEDDED enum
authorKees Cook <keescook@chromium.org>
Fri, 2 Oct 2020 17:38:14 +0000 (10:38 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Oct 2020 11:34:18 +0000 (13:34 +0200)
commit06e67b849ab910a49a629445f43edb074153d0eb
tree77c55ce1bcdc90f7098dbde98aba92dffcd93d19
parentc307459b9d1fcb8bbf3ea5a4162979532322ef77
fs/kernel_read_file: Remove FIRMWARE_EFI_EMBEDDED enum

The "FIRMWARE_EFI_EMBEDDED" enum is a "where", not a "what". It
should not be distinguished separately from just "FIRMWARE", as this
confuses the LSMs about what is being loaded. Additionally, there was
no actual validation of the firmware contents happening.

Fixes: e4c2c0ff00ec ("firmware: Add new platform fallback mechanism and firmware_request_platform()")
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Acked-by: Scott Branden <scott.branden@broadcom.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201002173828.2099543-3-keescook@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_loader/fallback_platform.c
include/linux/fs.h