firmware: tegra: Reduce stack usage
authorArnd Bergmann <arnd@arndb.de>
Mon, 27 Sep 2021 12:41:40 +0000 (14:41 +0200)
committerThierry Reding <treding@nvidia.com>
Thu, 7 Oct 2021 18:52:17 +0000 (20:52 +0200)
commit06c2d9a078abe784fd9fd0f1534e318e827712b4
tree95a9e0ff922e4abd9d9d0711a274559d992ead1c
parent6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
firmware: tegra: Reduce stack usage

Building the bpmp-debugfs driver for Arm results in a warning for stack usage:

drivers/firmware/tegra/bpmp-debugfs.c:321:16: error: stack frame size of 1224 bytes in function 'bpmp_debug_store' [-Werror,-Wframe-larger-than=]
static ssize_t bpmp_debug_store(struct file *file, const char __user *buf,

It should be possible to rearrange the code to not require two separate
buffers for the file name, but the easiest workaround is to use dynamic
allocation.

Fixes: 5e37b9c137ee ("firmware: tegra: Add support for in-band debug")
Link: https://lore.kernel.org/all/20201204193714.3134651-1-arnd@kernel.org/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[treding@nvidia.com: consistently return NULL on failure]
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/firmware/tegra/bpmp-debugfs.c