breakpad: Add FUNC records to the symtab
authorPavel Labath <pavel@labath.sk>
Tue, 22 Jan 2019 04:56:31 +0000 (04:56 +0000)
committerPavel Labath <pavel@labath.sk>
Tue, 22 Jan 2019 04:56:31 +0000 (04:56 +0000)
commit06bb373559a6014af36b7122b4a7048905a17166
tree080c9a571d9a08492c4028b2074e48a3ffa72f07
parent1efb72f8a404533e604f370e0e4cea4e948ae6e1
breakpad: Add FUNC records to the symtab

This patch extends SymbolFileBreakpad::AddSymbols to include the symbols
from the FUNC records too. These symbols come from the debug info and
have a size associated with them, so they are given preference in case
there is a PUBLIC record for the same address.

To achieve this, I first pre-process the symbols into a temporary
DenseMap, and then insert the uniqued symbols into the module's symtab.

Reviewers: clayborg, lemo, zturner

Reviewed By: clayborg

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D56590

llvm-svn: 351781
lldb/lit/SymbolFile/Breakpad/Inputs/symtab.syms
lldb/lit/SymbolFile/Breakpad/symtab.test
lldb/source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp
lldb/source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h
lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
lldb/unittests/ObjectFile/Breakpad/BreakpadRecordsTest.cpp