bpf: Fix XDP FD-based attach/detach logic around XDP_FLAGS_UPDATE_IF_NOEXIST
authorAndrii Nakryiko <andriin@fb.com>
Wed, 12 Aug 2020 02:29:23 +0000 (19:29 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Thu, 13 Aug 2020 01:00:49 +0000 (18:00 -0700)
commit068d9d1eba72423e99162aad3586727180715c2a
tree5a002b874b1bf8fc3f58ba74b3dd4d5c46bfe70c
parentda7bdfdd23b858e6d97a1e4b461548e23d16977f
bpf: Fix XDP FD-based attach/detach logic around XDP_FLAGS_UPDATE_IF_NOEXIST

Enforce XDP_FLAGS_UPDATE_IF_NOEXIST only if new BPF program to be attached is
non-NULL (i.e., we are not detaching a BPF program).

Fixes: d4baa9368a5e ("bpf, xdp: Extract common XDP program attachment logic")
Reported-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Tested-by: Stanislav Fomichev <sdf@google.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Link: https://lore.kernel.org/bpf/20200812022923.1217922-1-andriin@fb.com
net/core/dev.c