igb: Do not free q_vector unless new one was allocated
authorKees Cook <keescook@chromium.org>
Tue, 18 Oct 2022 09:25:24 +0000 (02:25 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 4 Nov 2022 18:09:57 +0000 (11:09 -0700)
commit0668716506ca66f90d395f36ccdaebc3e0e84801
tree10c16168c5a7b5ee0585f9ee917280bcdae882ae
parenteac0b6804b74dd77dd33ee4a0639b717481ebf54
igb: Do not free q_vector unless new one was allocated

Avoid potential use-after-free condition under memory pressure. If the
kzalloc() fails, q_vector will be freed but left in the original
adapter->q_vector[v_idx] array position.

Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igb/igb_main.c