pwm: cros-ec: Add __packed to prevent padding
authorBrian Norris <briannorris@chromium.org>
Tue, 26 Jul 2016 18:22:13 +0000 (11:22 -0700)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 6 Sep 2016 08:48:54 +0000 (10:48 +0200)
commit065cfbbb638cce3d388020c4b97813b4a904a7c3
tree9e71fe26e3bb9b045ff45a0d3074a1c5f71aad76
parentcd4b45ac449a01f0819b8459c451c840437aa0a3
pwm: cros-ec: Add __packed to prevent padding

While the particular usage in question is likely safe (struct
cros_ec_command is 32-bit aligned, followed by <= 32-bit fields), it's
been suggested this is not a great pattern to follow for the general
case -- for example, if we follow a 'struct cros_ec_command' (which is
32-bit- but not 64-bit-aligned) with a struct that starts with a 64-bit
type (e.g., u64), the compiler may add padding.

Let's add __packed, to inform the compiler of our true intention -- to
have no padding between these struct elements -- and to future proof for
any refactorings that might occur.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-cros-ec.c