Retire EwkViewMsg_DidFailLoadWithError
authorAntonio Gomes <a1.gomes@samsung.com>
Wed, 27 Jan 2016 05:16:12 +0000 (01:16 -0400)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 07:55:23 +0000 (07:55 +0000)
commit064acf8f8589332123d1d1f4e40241d8ed34bb22
tree42e83c30760cdd30f801ab546f74450c02b75c5d
parent1cfdc56a8829cdde6c2a67282c549e7c5f16794c
Retire EwkViewMsg_DidFailLoadWithError

Chromium has two messages renderer used to notify browser of a load fail:
FrameHostMsg_DidFailLoadWithError and
FrameHostMsg_DidCommitProvisionalLoad.

Although they are both sent to browser, their hooks are not actually
used by chromium-efl. Instead chromium-efl has a custom message for
its own use: EwkViewMsg_DidFailLoadWithError.

Patch removes EwkViewMsg_DidFailLoadWithError and its plumbing logic,
and use the hooks provided by the former two messages.

Previous stack:
- RenderFrameImpl::didFailLoad
- RenderViewObserverEfl::DidFailLoad
-  (IPC - EwkViewMsg_DidFailLoadWithError)
- WebViewBrowserMessageFilterPrivate::OnReceivedDidFailLoadWithError
- EWebView::InvokeLoadError

The stack is:
- RenderFrameImpl::didFailLoad
- (IPC - FrameHostMsg_DidFailLoadWithError)
- RenderFrameHostImpl::OnMessageReceived
- RenderFrameHostImpl::OnDidFailLoadWithError
- (..)
- WebContentsImpl::DidFailLoadWithError
- WebContentsDelegateEfl::DidFailLoad
- EWebView::InvokeLoadError

Original beta/m47 patch: http://165.213.202.130/gerrit/#/c/105526/

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=15697

Reviewed by: g.czajkowski

Change-Id: I680fe89af89bf98181cf02a47e585743f185a994
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
tizen_src/ewk/efl_integration/browser/web_view_browser_message_filter.cc
tizen_src/ewk/efl_integration/common/error_params.h [deleted file]
tizen_src/ewk/efl_integration/common/render_messages_ewk.h
tizen_src/ewk/efl_integration/efl_integration.gypi
tizen_src/ewk/efl_integration/eweb_view.cc
tizen_src/ewk/efl_integration/eweb_view.h
tizen_src/ewk/efl_integration/renderer/render_view_observer_efl.cc
tizen_src/ewk/efl_integration/renderer/render_view_observer_efl.h
tizen_src/ewk/efl_integration/web_contents_delegate_efl.cc
tizen_src/ewk/efl_integration/web_contents_delegate_efl.h