HID: hid-input: Fix accessing freed memory during device disconnect
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Mon, 3 Aug 2015 05:57:30 +0000 (14:57 +0900)
committerJiri Kosina <jkosina@suse.com>
Tue, 4 Aug 2015 13:45:44 +0000 (15:45 +0200)
commit0621809e37936e7c2b3eac9165cf2aad7f9189eb
treef9fcd7733397536f937b85aac58791e17b63f551
parent4a8e70f5d0d80675fc17b9ba1e62db8ca6b91775
HID: hid-input: Fix accessing freed memory during device disconnect

During unbinding the driver was dereferencing a pointer to memory
already freed by power_supply_unregister().

Driver was freeing its internal description of battery through pointers
stored in power_supply structure. However, because the core owns the
power supply instance, after calling power_supply_unregister() this
memory is freed and the driver cannot access these members.

Fix this by storing the pointer to internal description of battery in a
local variable before calling power_supply_unregister(), so the pointer
remains valid.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reported-by: H.J. Lu <hjl.tools@gmail.com>
Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core")
Cc: <stable@vger.kernel.org>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-input.c