lock_parent() needs to recheck if dentry got __dentry_kill'ed under it
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 24 Feb 2018 01:47:17 +0000 (20:47 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Mar 2018 08:18:00 +0000 (09:18 +0100)
commit05f16fe9ae8c18f461b25fd6f31c77333c739f58
tree5177d94c775af728d34d287bf37ffa58e38f6e31
parenteaa9592678a9553ba51493bbe0257f51e6638abd
lock_parent() needs to recheck if dentry got __dentry_kill'ed under it

commit 3b821409632ab778d46e807516b457dfa72736ed upstream.

In case when dentry passed to lock_parent() is protected from freeing only
by the fact that it's on a shrink list and trylock of parent fails, we
could get hit by __dentry_kill() (and subsequent dentry_kill(parent))
between unlocking dentry and locking presumed parent.  We need to recheck
that dentry is alive once we lock both it and parent *and* postpone
rcu_read_unlock() until after that point.  Otherwise we could return
a pointer to struct dentry that already is rcu-scheduled for freeing, with
->d_lock held on it; caller's subsequent attempt to unlock it can end
up with memory corruption.

Cc: stable@vger.kernel.org # 3.12+, counting backports
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/dcache.c