usb: gadget: f_fs: fix wrong parenthesis in ffs_func_req_match()
authorFelix Hädicke <felixhaedicke@web.de>
Thu, 3 Nov 2016 23:23:26 +0000 (00:23 +0100)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Fri, 18 Nov 2016 11:50:37 +0000 (13:50 +0200)
commit05e78c6933d613a7da0d0473f4c19c865af04c2c
treeaf263e55357cdce6dc940c0ae0c32eca934a252c
parenta25f0944ba9b1d8a6813fd6f1a86f1bd59ac25a6
usb: gadget: f_fs: fix wrong parenthesis in ffs_func_req_match()

Properly check the return code of ffs_func_revmap_intf() and
ffs_func_revmap_ep() for a non-negative value.

Instead of checking the return code, the comparison was performed for the last
parameter of the function calls, because of wrong parenthesis.

This also fixes the following static checker warning:
drivers/usb/gadget/function/f_fs.c:3152 ffs_func_req_match()
warn: always true condition '(((creq->wIndex)) >= 0) => (0-u16max >= 0)'

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felix Hädicke <felixhaedicke@web.de>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/function/f_fs.c