Correctly detect legacy iOS simulator Mach-O objectfiles
authorAdrian Prantl <aprantl@apple.com>
Wed, 5 Aug 2020 20:57:14 +0000 (13:57 -0700)
committerAdrian Prantl <aprantl@apple.com>
Thu, 6 Aug 2020 19:40:45 +0000 (12:40 -0700)
commit05df9cc70367a60cb34bee773389ab2522984f8b
tree878a94e993a08c608ab5b57b1b3274e0e49ceb47
parent128bf458ab8c5bdbb02e5b13769a618b357d5ae2
Correctly detect legacy iOS simulator Mach-O objectfiles

The code in ObjectFileMachO didn't disambiguate between ios and
ios-simulator object files for Mach-O objects using the legacy
ambiguous LC_VERSION_MIN load commands. This used to not matter before
taught ArchSpec that ios and ios-simulator are no longer compatible.

rdar://problem/66545307

Differential Revision: https://reviews.llvm.org/D85358
lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
lldb/source/Utility/ArchSpec.cpp
lldb/test/API/macosx/simulator/TestSimulatorPlatform.py
lldb/unittests/Utility/ArchSpecTest.cpp