ASoC: mediatek: mt8186-rt5682: primary_codec_init() warn: missing error code? 'ret'
authorAjye Huang <ajye_huang@compal.corp-partner.google.com>
Sat, 7 Jan 2023 17:59:33 +0000 (01:59 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 9 Jan 2023 13:05:32 +0000 (13:05 +0000)
commit05d450b06d6a299bd5a7f209c81db681c3cdbcd9
treedef36b450dcb43c500165399406ee71c9368ed0b
parentde1cae22898cf10aacc735a21d799b5bbce4496c
ASoC: mediatek: mt8186-rt5682: primary_codec_init() warn: missing error code? 'ret'

The function primary_codec_init() should return 0 if dmic_sel is null.

Here is the warning message reported by 0-DAY CI Kernel Test Service.

smatch warnings:
primary_codec_init() warn: missing error code? 'ret'
...
2022-11-02  141       if (!priv->dmic_sel) {
2022-11-02  142               dev_info(card->dev, "dmic_sel is null\n");
2022-11-02 @143               return ret;

return -EIVNAL;?  return 0;?

2022-11-02  144       }

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Link: https://lore.kernel.org/r/20230107175933.12973-1-ajye_huang@compal.corp-partner.google.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c