net: pxa168_eth: Fix a potential data race in pxa168_eth_remove
authorPavel Andrianov <andrianov@ispras.ru>
Wed, 10 Mar 2021 08:10:46 +0000 (11:10 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 10 Mar 2021 23:21:33 +0000 (15:21 -0800)
commit0571a753cb07982cc82f4a5115e0b321da89e1f3
treef750240bc836f82885e9dbb96e2a3bcd0af8bb21
parentdd4fa1dae9f4847cc1fd78ca468ad69e16e5db3e
net: pxa168_eth: Fix a potential data race in pxa168_eth_remove

pxa168_eth_remove() firstly calls unregister_netdev(),
then cancels a timeout work. unregister_netdev() shuts down a device
interface and removes it from the kernel tables. If the timeout occurs
in parallel, the timeout work (pxa168_eth_tx_timeout_task) performs stop
and open of the device. It may lead to an inconsistent state and memory
leaks.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Pavel Andrianov <andrianov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/pxa168_eth.c