[ELF] -z combreloc: sort dynamic relocations by (!is_relative,symbol_index,r_offset)
authorFangrui Song <maskray@google.com>
Mon, 20 May 2019 15:25:01 +0000 (15:25 +0000)
committerFangrui Song <maskray@google.com>
Mon, 20 May 2019 15:25:01 +0000 (15:25 +0000)
commit055906e1e50ddc35d6c8cdccab48ed83e93b47eb
tree3979652536adaef7ea39a107fbc33f57e3c274f9
parent1e593f342f00433c491c1f6db9dfe600a15ab2e8
[ELF] -z combreloc: sort dynamic relocations by (!is_relative,symbol_index,r_offset)

We currently sort dynamic relocations by (!is_relative,symbol_index).
Add r_offset as the third key. This makes `readelf -r` debugging easier
(relocations to the same symbol are ordered by r_offset).

Refactor the test combreloc.s (renamed from combrelocs.s) to check
R_X86_64_RELATIVE, and delete --expand-relocs.

The difference from the reverted D61477 is that we keep !is_relative as
the first key. In local dynamic TLS model, DTPMOD (e.g.
R_ARM_TLS_DTPMOD32 R_X86_64_DTPMOD and R_PPC{,64}_DTPMOD) may use 0 as
the symbol index.

Reviewed By: grimar

Differential Revision: https://reviews.llvm.org/D62141

llvm-svn: 361164
lld/ELF/SyntheticSections.cpp
lld/test/ELF/combreloc.s [new file with mode: 0644]
lld/test/ELF/combrelocs.s [deleted file]
lld/test/ELF/i386-got-and-copy.s