ALSA: seq: Fix function prototype mismatch in snd_seq_expand_var_event
authorKees Cook <keescook@chromium.org>
Fri, 18 Nov 2022 23:23:50 +0000 (15:23 -0800)
committerTakashi Iwai <tiwai@suse.de>
Sat, 19 Nov 2022 08:20:11 +0000 (09:20 +0100)
commit05530ef7cf7c7d700f6753f058999b1b5099a026
treeb4f0e3f1dbc81ac8fc2c224eaf33a3596a759caa
parent1abfd71ee8f3ed99c5d0df5d9843a360541d6808
ALSA: seq: Fix function prototype mismatch in snd_seq_expand_var_event

With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG),
indirect call targets are validated against the expected function
pointer prototype to make sure the call target is valid to help mitigate
ROP attacks. If they are not identical, there is a failure at run time,
which manifests as either a kernel panic or thread getting killed.

seq_copy_in_user() and seq_copy_in_kernel() did not have prototypes
matching snd_seq_dump_func_t. Adjust this and remove the casts. There
are not resulting binary output differences.

This was found as a result of Clang's new -Wcast-function-type-strict
flag, which is more sensitive than the simpler -Wcast-function-type,
which only checks for type width mismatches.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/202211041527.HD8TLSE1-lkp@intel.com
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20221118232346.never.380-kees@kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_memory.c