projects / platform / upstream / dotnet / runtime.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 6a81cfa) | patch
Ensure DiagnosticSource has correct package ID (#52472)
authorEric StJohn <ericstj@microsoft.com>
Sat, 8 May 2021 19:21:30 +0000 (12:21 -0700)
committerGitHub <noreply@github.com>
Sat, 8 May 2021 19:21:30 +0000 (12:21 -0700)
commit04e4a22db4e77a3f6c698e4cb4edda302212ad21
tree359f203bfc6319af21b6441fbb29335d87a17a2atree | snapshot
parent6a81cfa4e84ab55c26abb25d82ed7355c134a602commit | diff
Ensure DiagnosticSource has correct package ID (#52472)

The `AvoidRestoreCycleOnSelfReference` workaround was causing
DiagnosticSource to get the wrong PackageID in the assets file when
referenced by other projects.  This wasn't a problem when using pkgproj
since we'd calculate dependencies from assembly references, ignoring
the assets file.  This is a problem now that we're using csproj pack,
since that gets dependencies from the assets file.
eng/Versions.props diff | blob | history
src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSource.csproj diff | blob | history
src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj diff | blob | history
src/libraries/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.ilproj diff | blob | history
Domain: Dotnet / Core;