clamp to premul when reading premul sRGB
authorMike Klein <mtklein@chromium.org>
Tue, 13 Dec 2016 20:44:23 +0000 (15:44 -0500)
committerSkia Commit-Bot <skia-commit-bot@chromium.org>
Tue, 13 Dec 2016 22:09:57 +0000 (22:09 +0000)
commit04e10da8362a0dcabd795a4ad53f617719ca0d20
tree203575b49fb941990f0a19b288b6c6cc1eef9388
parent21f783829619186442041de6008f7f58f4f6250d
clamp to premul when reading premul sRGB

It's pretty easy to start with sound premultiplied linear floats, pack those to sRGB encoded bytes, then read them back to linear floats and find them not quite premultiplied, with a color channel just a smidge greater than the alpha channel.  This can happen basically any time we have different transfer functions for alpha and colors... sRGB being the only one we draw into.

This is an annoying problem with no known good solution.  So apply the clamp hammer.

These new calls on SkRasterPipeline should make it impossible to get wrong.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD

Change-Id: I4c974f4a7b151f3f684946f1e83d06b1b288fd01
Reviewed-on: https://skia-review.googlesource.com/5945
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
bench/SkRasterPipelineBench.cpp
src/core/SkConfig8888.cpp
src/core/SkRasterPipeline.cpp
src/core/SkRasterPipeline.h
src/core/SkRasterPipelineBlitter.cpp
src/image/SkImageShader.cpp
src/opts/SkRasterPipeline_opts.h