bpftool: JIT limited misreported as negative value on aarch64
authorAlan Maguire <alan.maguire@oracle.com>
Fri, 12 May 2023 11:31:34 +0000 (12:31 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 15 May 2023 19:14:48 +0000 (21:14 +0200)
commit04cb8453a91c7c22f60ddadb6cef0d19abb33bb5
treea6ae8e5e878720aa85492dcc45785f94f8500feb
parentd84b1a6708eec06b6cd9d33c5e0177bbd6ba4813
bpftool: JIT limited misreported as negative value on aarch64

On aarch64, "bpftool feature" reports an incorrect BPF JIT limit:

$ sudo /sbin/bpftool feature
Scanning system configuration...
bpf() syscall restricted to privileged users
JIT compiler is enabled
JIT compiler hardening is disabled
JIT compiler kallsyms exports are enabled for root
skipping kernel config, can't open file: No such file or directory
Global memory limit for JIT compiler for unprivileged users is -201326592 bytes

This is because /proc/sys/net/core/bpf_jit_limit reports

$ sudo cat /proc/sys/net/core/bpf_jit_limit
68169519595520

...and an int is assumed in read_procfs().  Change read_procfs()
to return a long to avoid negative value reporting.

Fixes: 7a4522bbef0c ("tools: bpftool: add probes for /proc/ eBPF parameters")
Reported-by: Nicky Veitch <nicky.veitch@oracle.com>
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Quentin Monnet <quentin@isovalent.com>
Link: https://lore.kernel.org/bpf/20230512113134.58996-1-alan.maguire@oracle.com
tools/bpf/bpftool/feature.c