usb: common: usb-conn-gpio: Set last role to unknown before initial detection
authorPrashanth K <quic_prashk@quicinc.com>
Wed, 31 May 2023 14:41:14 +0000 (20:11 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:55 +0000 (16:21 +0200)
commit04b1c0798deb567e79c245be8d4b6d88e1b3b20e
tree7fb653748e1258fc6d1e16fab5187dc197da656f
parent155bb9b4e32e63833d4c309e87d84d40ad888c0e
usb: common: usb-conn-gpio: Set last role to unknown before initial detection

[ Upstream commit edd60d24bd858cef165274e4cd6cab43bdc58d15 ]

Currently if we bootup a device without cable connected, then
usb-conn-gpio won't call set_role() since last_role is same as
current role. This happens because during probe last_role gets
initialised to zero.

To avoid this, added a new constant in enum usb_role, last_role
is set to USB_ROLE_UNKNOWN before performing initial detection.

While at it, also handle default case for the usb_role switch
in cdns3, intel-xhci-usb-role-switch & musb/jz4740 to avoid
build warnings.

Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Message-ID: <1685544074-17337-1-git-send-email-quic_prashk@quicinc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/cdns3/core.c
drivers/usb/common/usb-conn-gpio.c
drivers/usb/musb/jz4740.c
drivers/usb/roles/intel-xhci-usb-role-switch.c
include/linux/usb/role.h