leds-gpio: fix default state handling on OF platforms
authorAnton Vorontsov <avorontsov@ru.mvista.com>
Thu, 11 Mar 2010 21:58:47 +0000 (13:58 -0800)
committerRichard Purdie <rpurdie@linux.intel.com>
Tue, 16 Mar 2010 19:53:19 +0000 (19:53 +0000)
commit0493a4ff10959ff4c8e0d65efee25b7ffd4fa5db
tree805d40439515577d647d825223e051514fdc9e5c
parent72dcd8d08aca4ac6154dc37243880ee306c7ea73
leds-gpio: fix default state handling on OF platforms

The driver wrongly sets default state for LEDs that don't specify
default-state property.

Currently the driver handles default state this way:

memset(&led, 0, sizeof(led));
for_each_child_of_node(np, child) {
state = of_get_property(child, "default-state", NULL);
if (state) {
if (!strcmp(state, "keep"))
led.default_state = LEDS_GPIO_DEFSTATE_KEEP;
...
}
ret = create_gpio_led(&led, ...);
}

Which means that all LEDs that do not specify default-state will inherit
the last value of the default-state property, which is wrong.

This patch fixes the issue by moving LED's template initialization into
the loop body.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
drivers/leds/leds-gpio.c