batman-adv: Avoid spurious warnings from bat_v neigh_cmp implementation
authorSven Eckelmann <sven.eckelmann@openmesh.com>
Mon, 16 Mar 2020 22:30:49 +0000 (23:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Mar 2020 08:07:52 +0000 (09:07 +0100)
commit0478b59311abcae3393b2e8fc22d191b94438a75
treeb45814d8de05273364552932d8ab7b24011a157c
parent805596e6a8076b9a22aa80780536ed430e38f655
batman-adv: Avoid spurious warnings from bat_v neigh_cmp implementation

commit 6a4bc44b012cbc29c9d824be2c7ab9eac8ee6b6f upstream.

The neighbor compare API implementation for B.A.T.M.A.N. V checks whether
the neigh_ifinfo for this neighbor on a specific interface exists. A
warning is printed when it isn't found.

But it is not called inside a lock which would prevent that this
information is lost right before batadv_neigh_ifinfo_get. It must therefore
be expected that batadv_v_neigh_(cmp|is_sob) might not be able to get the
requested neigh_ifinfo.

A WARN_ON for such a situation seems not to be appropriate because this
will only flood the kernel logs. The warnings must therefore be removed.

Signed-off-by: Sven Eckelmann <sven.eckelmann@openmesh.com>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/batman-adv/bat_v.c