[coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in...
authorGor Nishanov <GorNishanov@gmail.com>
Sat, 11 Nov 2017 17:00:43 +0000 (17:00 +0000)
committerGor Nishanov <GorNishanov@gmail.com>
Sat, 11 Nov 2017 17:00:43 +0000 (17:00 +0000)
commit04491bd8f324bce9d2adbc9cc6e45f0d1659ac41
tree3fe744167112646b34709aad1180d71b90eab244
parentd0ef19ef9b2c4c61ecd10b133632c795c3bc2d31
[coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in the coroutine frame

Summary:
We don't want to store cleanup dest slot saved into the coroutine frame (as some of the cleanup code may
access them after coroutine frame destroyed).

This is an alternative to https://reviews.llvm.org/D37093

It is possible to do this for all functions, but, cursory check showed that in -O0, we get slightly longer function (by 1-3 instructions), thus, we are only limiting cleanup.dest.slot elimination to coroutines.

Reviewers: rjmccall, hfinkel, eric_niebler

Reviewed By: eric_niebler

Subscribers: EricWF, cfe-commits

Differential Revision: https://reviews.llvm.org/D39768

llvm-svn: 317981
clang/lib/CodeGen/CodeGenFunction.cpp
clang/lib/CodeGen/CodeGenFunction.h
clang/test/CodeGenCoroutines/coro-dest-slot.cpp [new file with mode: 0644]