Don't fail step out if remote server doesn't implement qMemoryRegionInfo
authorTed Woodward <ted.woodward@codeaurora.org>
Tue, 28 Jan 2020 19:31:40 +0000 (13:31 -0600)
committerTed Woodward <ted.woodward@codeaurora.org>
Tue, 28 Jan 2020 19:36:06 +0000 (13:36 -0600)
commit04488c485a8875ba4bd6d2d004ac778276ae37e0
tree5583cf0317cf29bb87e64d6abe17e882fc8a69c4
parent90a10f00ff838f6031e225f11b72a7e9240e288f
Don't fail step out if remote server doesn't implement qMemoryRegionInfo

Summary:
The return address validation in D71372 will fail if the memory permissions can't be determined. Many embedded stubs either don't implement the qMemoryRegionInfo packet, or don't have memory permissions at all.

Remove the return from the if clause that calls GetLoadAddressPermissions, so this call failing doesn't cause the step out to abort. Instead, assume that the memory permission check doesn't apply to this type of target.

Reviewers: labath, jingham, clayborg, mossberg

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D72513
lldb/source/Target/ThreadPlanStepOut.cpp