media: mc-entity.c: use & to check pad flags, not ==
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 4 Feb 2020 18:19:22 +0000 (19:19 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 24 Feb 2020 14:10:04 +0000 (15:10 +0100)
commit044041cd5227ec9ccf969f4bf1cc08bffe13b9d3
tree202e1fc96d6097fc8912594604284ce955f3393b
parent316e730f1d8bb029fe6cec2468fb2a50424485b3
media: mc-entity.c: use & to check pad flags, not ==

These are bits so to test if a pad is a sink you use & but not ==.

It looks like the only reason this hasn't caused problems before is that
media_get_pad_index() is currently only used with pads that do not set the
MEDIA_PAD_FL_MUST_CONNECT flag. So a pad really had only the SINK or SOURCE
flag set and nothing else.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: <stable@vger.kernel.org> # for v5.3 and up
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/mc/mc-entity.c