media: allegro: fix potential null dereference on header
authorColin Ian King <colin.king@canonical.com>
Wed, 22 Jul 2020 13:09:03 +0000 (15:09 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 6 Aug 2020 09:28:04 +0000 (11:28 +0200)
commit04320b3ef90bef04df6672e3a98a266b88c35b55
tree01cb6666e1b8a07a41c6d128303441f234f6ac11
parentdd4eddc4ba31fbf4554fc5fa12d3a553b50e1469
media: allegro: fix potential null dereference on header

The pointer header is an alias to msg and msg is being null checked.
However, if msg is null then header is also null and this can lead to
a null pointer dereference on the assignment type = header->type. Fix
this just using header->type after the null check and removing the need
for type as it is only used once.

Addresses-Coverity: ("Dereference before null check")

Fixes: 3de16839669f ("media: allegro: add explicit mail encoding and decoding")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/allegro-dvt/allegro-mail.c