Support lazy stat'ing of files referenced by module maps.
authorRichard Smith <richard-llvm@metafoo.co.uk>
Fri, 2 Jun 2017 01:55:39 +0000 (01:55 +0000)
committerRichard Smith <richard-llvm@metafoo.co.uk>
Fri, 2 Jun 2017 01:55:39 +0000 (01:55 +0000)
commit040e12662a674e2ebfc93f86a70eddb7d6fc76da
tree584207a7572d85ef6f3fefca3395edfccc7e6e00
parentae80045debdd1c46bfa233c87247182862bf4437
Support lazy stat'ing of files referenced by module maps.

This patch adds support for a `header` declaration in a module map to specify
certain `stat` information (currently, size and mtime) about that header file.
This has two purposes:

- It removes the need to eagerly `stat` every file referenced by a module map.
  Instead, we track a list of unresolved header files with each size / mtime
  (actually, for simplicity, we track submodules with such headers), and when
  attempting to look up a header file based on a `FileEntry`, we check if there
  are any unresolved header directives with that `FileEntry`'s size / mtime and
  perform deferred `stat`s if so.

- It permits a preprocessed module to be compiled without the original files
  being present on disk. The only reason we used to need those files was to get
  the `stat` information in order to do header -> module lookups when using the
  module. If we're provided with the `stat` information in the preprocessed
  module, we can avoid requiring the files to exist.

Unlike most `header` directives, if a `header` directive with `stat`
information has no corresponding on-disk file the enclosing module is *not*
marked unavailable (so that behavior is consistent regardless of whether we've
resolved a header directive, and so that preprocessed modules don't get marked
unavailable). We could actually do this for all `header` directives: the only
reason we mark the module unavailable if headers are missing is to give a
diagnostic slightly earlier (rather than waiting until we actually try to build
the module / load and validate its .pcm file).

Differential Revision: https://reviews.llvm.org/D33703

llvm-svn: 304515
20 files changed:
clang/docs/Modules.rst
clang/include/clang/Basic/DiagnosticLexKinds.td
clang/include/clang/Basic/DiagnosticSerializationKinds.td
clang/include/clang/Basic/Module.h
clang/include/clang/Lex/ModuleMap.h
clang/lib/Basic/Module.cpp
clang/lib/Frontend/FrontendAction.cpp
clang/lib/Lex/HeaderSearch.cpp
clang/lib/Lex/ModuleMap.cpp
clang/lib/Lex/PPDirectives.cpp
clang/lib/Serialization/ASTWriter.cpp
clang/test/Modules/Inputs/header-attribs/bar.h [new file with mode: 0644]
clang/test/Modules/Inputs/header-attribs/baz.h [new file with mode: 0644]
clang/test/Modules/Inputs/header-attribs/foo.h [new file with mode: 0644]
clang/test/Modules/Inputs/header-attribs/modular.modulemap [new file with mode: 0644]
clang/test/Modules/Inputs/header-attribs/textual.modulemap [new file with mode: 0644]
clang/test/Modules/diagnostics.modulemap
clang/test/Modules/header-attribs.cpp [new file with mode: 0644]
clang/test/Modules/preprocess-missing.modulemap [new file with mode: 0644]
clang/test/Modules/preprocess-module.cpp