skbuff: Switch structure bounds to struct_group()
authorKees Cook <keescook@chromium.org>
Sun, 21 Nov 2021 00:31:49 +0000 (16:31 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Nov 2021 15:13:54 +0000 (15:13 +0000)
commit03f61041c17914355dde7261be9ccdc821ddd454
treebd95497df8f59b9729f69d97ac8092e48e0523c9
parentfba84957e2e2e201cf4e352efe0c7cac0fbb5d5d
skbuff: Switch structure bounds to struct_group()

In preparation for FORTIFY_SOURCE performing compile-time and run-time
field bounds checking for memcpy(), memmove(), and memset(), avoid
intentionally writing across neighboring fields.

Replace the existing empty member position markers "headers_start" and
"headers_end" with a struct_group(). This will allow memcpy() and sizeof()
to more easily reason about sizes, and improve readability.

"pahole" shows no size nor member offset changes to struct sk_buff.
"objdump -d" shows no object code changes (outside of WARNs affected by
source line number changes).

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com> # drivers/net/wireguard/*
Link: https://lore.kernel.org/lkml/20210728035006.GD35706@embeddedor
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wireguard/queueing.h
include/linux/skbuff.h
net/core/skbuff.c