CIFS: avoid using MID 0xFFFF
authorRoberto Bergantinos Corpas <rbergant@redhat.com>
Mon, 14 Oct 2019 08:59:23 +0000 (10:59 +0200)
committerSteve French <stfrench@microsoft.com>
Mon, 21 Oct 2019 00:19:49 +0000 (19:19 -0500)
commit03d9a9fe3f3aec508e485dd3dcfa1e99933b4bdb
tree73bb8587830b41af04ab1e8d3824133cd003ee47
parent553292a6342bc9e5636953ac6e20bccedaacbd1c
CIFS: avoid using MID 0xFFFF

According to MS-CIFS specification MID 0xFFFF should not be used by the
CIFS client, but we actually do. Besides, this has proven to cause races
leading to oops between SendReceive2/cifs_demultiplex_thread. On SMB1,
MID is a 2 byte value easy to reach in CurrentMid which may conflict with
an oplock break notification request coming from server

Signed-off-by: Roberto Bergantinos Corpas <rbergant@redhat.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
CC: Stable <stable@vger.kernel.org>
fs/cifs/smb1ops.c