Revert "net: dsa: qca8k: cache lo and hi for mdio write"
authorChristian Marangi <ansuelsmth@gmail.com>
Thu, 29 Dec 2022 16:33:34 +0000 (17:33 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 Jan 2023 09:27:12 +0000 (09:27 +0000)
commit03cb9e6d0b32b768e3d9d473c5c4ca1100877664
tree1fcbd906b0177735429e93cab19802f41d9620b5
parentd9dba91be71f03cc75bcf39fc0d5d99ff33f1ae0
Revert "net: dsa: qca8k: cache lo and hi for mdio write"

This reverts commit 2481d206fae7884cd07014fd1318e63af35e99eb.

The Documentation is very confusing about the topic.
The cache logic for hi and lo is wrong and actually miss some regs to be
actually written.

What the Documentation actually intended was that it's possible to skip
writing hi OR lo if half of the reg is not needed to be written or read.

Revert the change in favor of a better and correct implementation.

Reported-by: Ronald Wahl <ronald.wahl@raritan.com>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Cc: stable@vger.kernel.org # v5.18+
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/qca/qca8k-8xxx.c
drivers/net/dsa/qca/qca8k.h